Review Request 108439: base visualization of inline objects on text color, instead of hardcoding to gray

Friedrich W. H. Kossebau kossebau at kde.org
Wed Jan 16 14:21:44 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108439/
-----------------------------------------------------------

Review request for Calligra and C. Boemann.


Description
-------

Hardcoding to gray works with black text on white background, but not so nice with other colors.

So I propose to use instead the textcolor with some transparency to paint the background of an inline object.
Should have the same effect like the original setting, but also work and look nice with other color conditions.


Diffs
-----

  libs/textlayout/KoTextDocumentLayout.cpp 15548d7 

Diff: http://git.reviewboard.kde.org/r/108439/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130116/a1711a10/attachment.htm>


More information about the calligra-devel mailing list