Review Request 107766: remove QT3SUPPORT condition for icalendar plugin

[Boudewijn Rempt]

> On Jan. 14, 2013, 11:19 p.m., Inge Wallin wrote:
> > Boud?

I'm only guessing that at the time it was necessary...


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107766/#review25541
-----------------------------------------------------------


On Dec. 16, 2012, 7:52 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107766/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 7:52 p.m.)
> 
> 
> Review request for Calligra, Dag Andersen and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> With commit e8d21556c511c917f91c11f12834767ad7c23c83 Boudewijn added the option to switch off everything that needs Qt3Support.
> 
> But I wonder why the icalendar plugin has been added to these which are switched off, at least it does not use Q3 stuff directly (nor seem the included kcal headers or libkcal to do so, at least of version 4.8, but https://projects.kde.org/projects/kde/kdepimlibs/repository/entry/kcal/CMakeLists.txt?rev=KDE%2F4.3 hints that at SC 4.3 this was the same).
> 
> Was that by accident, so the attached patch which removes that condition can be committed?
> Or do I miss something?
> 
> 
> Diffs
> -----
> 
>   plan/plugins/filters/CMakeLists.txt a2b2636 
> 
> Diff: http://git.reviewboard.kde.org/r/107766/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130115/04da0c31/attachment.htm>