Review Request 108295: Setting working environment on launching in Windows

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108295/#review25456
-----------------------------------------------------------

Ship it!


Looks good to me.

- Boudewijn Rempt


On Jan. 14, 2013, 1:22 p.m., Stuart Dickson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108295/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 1:22 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> In order to allow Calligra applications to be run as pre-built binaries on Windows operating system, some environment variables need to be set in order to allow plugins etc to be correctly found.
> 
> Previously, the packaged version of the applications used a combination of batch file and VBS script in order to set the environment invisibly to the user before launching the application.
> 
> The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, flow) to be launched directly.
> This also resolves occasional issues where scripting was not correctly installed, or was not available to the user.
> It also makes possible associating the Calligra applications against document file types.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoApplication.cpp 6a71458 
> 
> Diff: http://git.reviewboard.kde.org/r/108295/diff/
> 
> 
> Testing
> -------
> 
> Built and run on Windows system, demonstrated to work with existing packaging setup.
> Modifications are wrapped in an OS-centric block (with the exception of the additional headers required), so this willl not affect Linux builds.
> 
> 
> Thanks,
> 
> Stuart Dickson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130114/c2789972/attachment.htm>