Review Request 108220: Readd formats menu (Select Masterpage, Edit Page layout) to Flow

Commit Hook null at kde.org
Mon Jan 14 03:30:52 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108220/#review25417
-----------------------------------------------------------


This review has been submitted with commit 7d8a9be7dd79f9b2b5cf2fe16e1e509ecbd9d487 by Inge Wallin on behalf of Friedrich W. H. Kossebau to branch text-annotations-ingwa.

- Commit Hook


On Jan. 6, 2013, 4:03 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108220/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 4:03 a.m.)
> 
> 
> Review request for Calligra and Yue Liu.
> 
> 
> Description
> -------
> 
> KoPAView::initActions() is adding actions for selecting the "Master Page..." and setting the "Page Layout...", but they do not make it into the menu of Calligra Flow, because the flow.rc misses to have the proper entries "format_masterpage" and "format_pagelayout" (and these are also not part of "ui_standards.rc").
> 
> Attached patch adds a menu "Format" with the two entries, for consistency like Stage has (though Stage adds own menu entries as well).
> 
> Okay to also backport to 2.6?
> 
> There is one flaw, but that also exist with Stage now: switching to another format does not trigger a repaint. Has to be fixed separately.
> 
> 
> Diffs
> -----
> 
>   flow/part/flow.rc 3e90a63 
> 
> Diff: http://git.reviewboard.kde.org/r/108220/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130114/e470abde/attachment.htm>


More information about the calligra-devel mailing list