Review Request 107913: Kexi: Add "Save As" action for any database object

[Jarosław Staniek]

> On Jan. 13, 2013, 9:46 p.m., Adam Pigg wrote:
> > kexi/main/KexiMainWindow.cpp, line 2816
> > <http://git.reviewboard.kde.org/r/107913/diff/1/?file=101225#file101225line2816>
> >
> >     should this be implemented?

Some day; for false will be propagated up and Kexi will show error message anyway.


> On Jan. 13, 2013, 9:46 p.m., Adam Pigg wrote:
> > kexi/main/KexiMainWindow.cpp, line 2827
> > <http://git.reviewboard.kde.org/r/107913/diff/1/?file=101225#file101225line2827>
> >
> >     Change to an enum?

Sure but it's loosely related, I propose to do it later to minimize this patch.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107913/#review25405
-----------------------------------------------------------


On Dec. 26, 2012, 12:04 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107913/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2012, 12:04 a.m.)
> 
> 
> Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, and Radosław Wicik.
> 
> 
> Description
> -------
> 
> Kexi: Add "Save As" action for any database object
> 
> - it's long awaited feature
> - the operation works on server side if possible
> - since the action is less frequently used, its place is in the "Main Menu" of the object itself, a new feature of Kexi 2.7 GUI
> 
> 
> Diffs
> -----
> 
>   kexi/core/KexiMainWindowIface.h 7bc7ed0b63a320fbe1bd34b4a69c8398cd5abd7c 
>   kexi/core/KexiView.h 491b0fb69698f369c7b64d50f76c28b4c8bc31c9 
>   kexi/core/KexiView.cpp 1ad591c6147624128aeaf6901f99bb64c94eb944 
>   kexi/core/KexiWindow.h ca0cdc601423894241f14fd286e861398beba993 
>   kexi/core/KexiWindow.cpp fb0a8dc6d21197a22c80bf1e77f9a2435e56bd45 
>   kexi/core/kexiproject.h 639eff1c5d4abe7cffc7deff0b40fe9ef7a97898 
>   kexi/core/kexiproject.cpp 239a95e96673ebb144bc2396d33ad820ea002c31 
>   kexi/main/KexiMainWindow.h cf21691f1298cd70537acf1957ea774ab0dea762 
>   kexi/main/KexiMainWindow.cpp a6fe369f86b4149d586b2c724d3e30d4a70414ad 
>   kexi/plugins/tables/kexitabledesignerview.h 2290364712fd619f15fcd4d63ba46e77cb9f465b 
>   kexi/plugins/tables/kexitabledesignerview.cpp 754dc6c1814dfd13f19f5fcd5a2eb828f34edba7 
>   kexi/plugins/tables/kexitablepart.cpp 08842ba07d70095966cabbd21f3894c951235ea9 
>   kexi/widget/KexiNameDialog.h aededf0034d6edc2924531566e8a8df7d6601e83 
>   kexi/widget/KexiNameDialog.cpp 91ac5ed259bbbbbe7cc96dfa5960490b36c09f90 
>   kexi/widget/KexiNameWidget.h 6430f5be09f6cc7ce88186c062dcfd0d34c4bfe6 
>   libs/db/connection.h c37119f9fa382b97920328bee010ccb8b94d2bca 
>   libs/db/connection.cpp 97f1234eaf22976961830f9be3f48e58a273cc44 
> 
> Diff: http://git.reviewboard.kde.org/r/107913/diff/
> 
> 
> Testing
> -------
> 
> Tested with all types of Kexi objects, tested all overwriting cases
> 
> 
> Screenshots
> -----------
> 
> Save As action in Table Designer
>   http://git.reviewboard.kde.org/r/107913/s/930/
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130113/4df57375/attachment.htm>