Review Request 108368: page breaks CAN be inherited
Thorsten Zachmann
t.zachmann at zagge.de
Sun Jan 13 04:03:04 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108368/#review25324
-----------------------------------------------------------
Ship it!
I did a run with cstester and it did not show any regressions. The code looks good to me. Please commit.
- Thorsten Zachmann
On Jan. 12, 2013, 2:03 p.m., C. Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108368/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2013, 2:03 p.m.)
>
>
> Review request for Calligra and Thorsten Zachmann.
>
>
> Description
> -------
>
> Remove code saying pagebreaks can't be inherited, but my testing with LO shows that it can,
> and there is no mention the odf spec it can't
>
>
> Diffs
> -----
>
> libs/kotext/styles/KoParagraphStyle.cpp 932cd07
>
> Diff: http://git.reviewboard.kde.org/r/108368/diff/
>
>
> Testing
> -------
>
> only with a simple file
>
> cs tester run needed
>
>
> Thanks,
>
> C. Boemann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130113/67482dd6/attachment.htm>
More information about the calligra-devel
mailing list