Review Request: Improved VisualImageCompare #2

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108322/#review25212
-----------------------------------------------------------


Nice work. Please fix the thinks I pointed out. Then we are ready to take it in.


tools/cstester/visualimagecompare/CSTCompareView.cpp
<http://git.reviewboard.kde.org/r/108322/#comment19257>

    The variable is no longer used. Please remove.



tools/cstester/visualimagecompare/CSTCompareView.cpp
<http://git.reviewboard.kde.org/r/108322/#comment19259>

    Please change the Preferred to Ingnored. Only with that change it works without expanding for me.



tools/cstester/visualimagecompare/CSTCompareView.cpp
<http://git.reviewboard.kde.org/r/108322/#comment19258>

    This method is no longer needed. Please remove.


- Thorsten Zachmann


On Jan. 10, 2013, 6:30 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108322/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 6:30 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8034206
> 
> The window does not resize when the document name is longer than the window. The full title is still visible. The user also can see the total number of files that have changes.
> 
> 
> Diffs
> -----
> 
>   tools/cstester/visualimagecompare/CSTCompareView.h 132f6d8 
>   tools/cstester/visualimagecompare/CSTCompareView.cpp 6bf118c 
> 
> Diff: http://git.reviewboard.kde.org/r/108322/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130111/1f60b1d8/attachment.htm>