Review Request: Improved VisualImageCompare #2

Thorsten Zachmann t.zachmann at zagge.de
Thu Jan 10 17:26:08 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108322/#review25174
-----------------------------------------------------------



tools/cstester/visualimagecompare/CSTCompareView.cpp
<http://git.reviewboard.kde.org/r/108322/#comment19242>

    While this works I think it would would be better to use 1 as column and use columnStretch for the other rows.



tools/cstester/visualimagecompare/CSTCompareView.cpp
<http://git.reviewboard.kde.org/r/108322/#comment19243>

    There seems to be a problem here as I can see resizing happening with the filename 
    
    az12722.vo.msecnd.net%2Fsharepointandsilverlighttrainingcourse2-%30%2Flabs%2Freportingonsilverlightusagedatalab1-%30-%30%2FLab.docx


- Thorsten Zachmann


On Jan. 10, 2013, 4:01 p.m., Mohammed Nafees wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108322/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 4:01 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2012/8034206
> 
> The window does not resize when the document name is longer than the window. The full title is still visible. The user also can see the total number of files that have changes.
> 
> 
> Diffs
> -----
> 
>   tools/cstester/visualimagecompare/CSTCompareView.h 132f6d8 
>   tools/cstester/visualimagecompare/CSTCompareView.cpp 6bf118c 
> 
> Diff: http://git.reviewboard.kde.org/r/108322/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mohammed Nafees
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130110/a53e3474/attachment.htm>


More information about the calligra-devel mailing list