Review Request: Fix a number of Krazy issues: source files not ending in newline

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108317/#review25124
-----------------------------------------------------------


Interesting... Seems that the reviewboard cannot handle this type of patch. But take my word for that the patch contains a fix for all of http://englishbreakfastnetwork.org/krazy/reports/bundled-apps/calligra/filters/index.html, section 8: "Check that file ends with a newline [endswithnewline]...OOPS! 47 issues found!"

- Inge Wallin


On Jan. 10, 2013, 6:41 a.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108317/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 6:41 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch adds a final newline to some source files that don't have them. This is one of the issues that are flagged in the code checker at http://englishbreakfastnetwork.org/krazy/index.php?component=bundled-apps&module=calligra. 
> 
> In all of Calligra there are lots of small issues like this, though this particular type is especially trivial. So I wrote a utility tools/fixsrc.py that is intended to find and fix things that are just too trivial to do manually. 
> 
> But how shall we handle it? I applied the script in a place that I thought would not be very controversial: the filters. But how to continue? I can see several choices we need to make:
>  - Leave some of the issues be? In that case we should disable the check in EBN.
>  - Apply them to all the sources in one big swoop? Or per module?
>  - Backport or not? I would prefer to apply the same type of patch in at least master and 2.6 to maximize the backportability of other patches.
> 
> 
> Diffs
> -----
> 
>   filters/words/msword-odf/wv2/src/olestream.cpp c778962 
>   filters/words/rtf/import/rtf-qt/src/AbstractRtfOutput.h 00ba298 
>   filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.h 855367b 
>   filters/words/rtf/import/rtf-qt/src/AuthorPcdataDestination.cpp edfad34 
>   filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.h 45f233f 
>   filters/words/rtf/import/rtf-qt/src/CategoryPcdataDestination.cpp ca4444f 
>   filters/words/rtf/import/rtf-qt/src/ColorTableDestination.h 01d7abf 
>   filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.h 683220f 
>   filters/words/rtf/import/rtf-qt/src/CommentPcdataDestination.cpp 3db8c61 
>   filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.h dc59149 
>   filters/words/rtf/import/rtf-qt/src/CompanyPcdataDestination.cpp 67fdaef 
>   filters/words/rtf/import/rtf-qt/src/Destination.cpp faa3aa2 
>   filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.h fdbc7e0 
>   filters/words/rtf/import/rtf-qt/src/DocumentCommentPcdataDestination.cpp 993cd42 
>   filters/words/rtf/import/rtf-qt/src/DocumentDestination.cpp 3b278b3 
>   filters/words/rtf/import/rtf-qt/src/FontTableDestination.cpp 2fda530 
>   filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.h 87a7373 
>   filters/words/rtf/import/rtf-qt/src/GeneratorPcdataDestination.cpp d51cc1c 
>   filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.h f391cbd 
>   filters/words/rtf/import/rtf-qt/src/HLinkBasePcdataDestination.cpp 26a0646 
>   filters/words/rtf/import/rtf-qt/src/IgnoredDestination.cpp d273880 
>   filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.h 3134ef9 
>   filters/words/rtf/import/rtf-qt/src/InfoCreatedTimeDestination.cpp 9f0dbb0 
>   filters/words/rtf/import/rtf-qt/src/InfoDestination.h 518fbbd 
>   filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.h 3c835f4 
>   filters/words/rtf/import/rtf-qt/src/InfoPrintedTimeDestination.cpp 3fb1b8f 
>   filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.h 106cb37 
>   filters/words/rtf/import/rtf-qt/src/InfoRevisedTimeDestination.cpp 62fbf7c 
>   filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.h 03fb8cb 
>   filters/words/rtf/import/rtf-qt/src/InfoTimeDestination.cpp 3f5e27c 
>   filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.h 41ac5b3 
>   filters/words/rtf/import/rtf-qt/src/KeywordsPcdataDestination.cpp e843d9a 
>   filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.h 0431a5f 
>   filters/words/rtf/import/rtf-qt/src/ManagerPcdataDestination.cpp b16f474 
>   filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.h 7c7b074 
>   filters/words/rtf/import/rtf-qt/src/OperatorPcdataDestination.cpp 510db79 
>   filters/words/rtf/import/rtf-qt/src/PcdataDestination.h edd0e89 
>   filters/words/rtf/import/rtf-qt/src/PcdataDestination.cpp b266aec 
>   filters/words/rtf/import/rtf-qt/src/StyleSheetDestination.cpp a5d4f86 
>   filters/words/rtf/import/rtf-qt/src/SubjectPcdataDestination.h 508625a 
>   filters/words/rtf/import/rtf-qt/src/SubjectPcdataDestination.cpp bdb51a0 
>   filters/words/rtf/import/rtf-qt/src/TextDocumentRtfOutput.h 5184ae8 
>   filters/words/rtf/import/rtf-qt/src/TitlePcdataDestination.h d80c751 
>   filters/words/rtf/import/rtf-qt/src/TitlePcdataDestination.cpp 15abb42 
>   filters/words/rtf/import/rtf-qt/src/Token.cpp 84a5b0a 
>   filters/words/rtf/import/rtf-qt/src/Tokenizer.h 27a59bd 
>   filters/words/rtf/import/rtf-qt/src/UserPropsDestination.h 846459a 
> 
> Diff: http://git.reviewboard.kde.org/r/108317/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130110/e45b768b/attachment.htm>