Review Request: Readd formats menu (Select Masterpage, Edit Page layout) to Flow

[Yue Liu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108220/#review25116
-----------------------------------------------------------

Ship it!


- Yue Liu


On Jan. 6, 2013, 4:03 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108220/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 4:03 a.m.)
> 
> 
> Review request for Calligra and Yue Liu.
> 
> 
> Description
> -------
> 
> KoPAView::initActions() is adding actions for selecting the "Master Page..." and setting the "Page Layout...", but they do not make it into the menu of Calligra Flow, because the flow.rc misses to have the proper entries "format_masterpage" and "format_pagelayout" (and these are also not part of "ui_standards.rc").
> 
> Attached patch adds a menu "Format" with the two entries, for consistency like Stage has (though Stage adds own menu entries as well).
> 
> Okay to also backport to 2.6?
> 
> There is one flaw, but that also exist with Stage now: switching to another format does not trigger a repaint. Has to be fixed separately.
> 
> 
> Diffs
> -----
> 
>   flow/part/flow.rc 3e90a63 
> 
> Diff: http://git.reviewboard.kde.org/r/108220/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130110/8b6da159/attachment.htm>