Review Request: Setting working environment on launching in Windows

Stuart Dickson stuartmd at kogmbh.com
Wed Jan 9 15:27:27 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108295/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

In order to allow Calligra applications to be run as pre-built binaries on Windows operating system, some environment variables need to be set in order to allow plugins etc to be correctly found.

Previously, the packaged version of the applications used a combination of batch file and VBS script in order to set the environment invisibly to the user before launching the application.

The patch allows the Calligra binaries (words, sheets, stage, karbon, plan, flow) to be launched directly.
This also resolves occasional issues where scripting was not correctly installed, or was not available to the user.
It also makes possible associating the Calligra applications against document file types.


Diffs
-----

  flow/part/main.cpp 67d1926 
  karbon/main.cpp 4e90edb 
  plan/main.cpp 96f0b7a 
  sheets/part/Main.cpp facda77 
  stage/part/main.cpp 5ef9509 
  words/part/main.cpp 875eb5d 

Diff: http://git.reviewboard.kde.org/r/108295/diff/


Testing
-------

Built and run on Windows system, demonstrated to work with existing packaging setup.
Modifications are wrapped in an OS-centric block (with the exception of the additional headers required), so this willl not affect Linux builds.


Thanks,

Stuart Dickson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130109/e9649a18/attachment.htm>


More information about the calligra-devel mailing list