Review Request: update all views on KoPAPages on change of layout
Friedrich W. H. Kossebau
kossebau at kde.org
Sun Jan 6 14:44:08 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108228/
-----------------------------------------------------------
Review request for Calligra and Thorsten Zachmann.
Description
-------
Currently KoPAChangePageLayoutCommand & Co. call emitUpdate() on the document, but to no result, as noone is listening to the update() signal of the KoPADocument.
Attached patch changes that for KoPADocumentModel, KoPAView and KPrSlidesSorterDocumentModel. Any other view on KoPAPages I missed?
Simply calling update() everywhere might be inefficient, but follows the handling of any shape changes, so consistent :)
Okay to backport to 2.6?
Diffs
-----
libs/kopageapp/KoPADocumentModel.cpp f51b5e6
libs/kopageapp/KoPAView.cpp 62e9a7b
stage/part/KPrSlidesSorterDocumentModel.cpp f860024
Diff: http://git.reviewboard.kde.org/r/108228/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130106/c958cc25/attachment.htm>
More information about the calligra-devel
mailing list