Review Request: Flow, Karbon, Stage and Sheets: use the currently set size units in the pagelayout dialog

Inge Wallin inge at lysator.liu.se
Sun Jan 6 05:30:36 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108221/#review24787
-----------------------------------------------------------

Ship it!


This can only be good.  And the code looks ok.

- Inge Wallin


On Jan. 6, 2013, 4:11 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108221/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 4:11 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Words does it, but Flow, Karbon, Stage and Sheets don't: use the currently set size units in the pagelayout dialog.
> 
> Attached patch fixes that.
> 
> Okay to backport to 2.6?
> 
> 
> This addresses bug 312690.
>     http://bugs.kde.org/show_bug.cgi?id=312690
> 
> 
> Diffs
> -----
> 
>   karbon/ui/KarbonView.cpp 6f8bf72 
>   libs/kopageapp/dialogs/KoPAPageLayoutDialog.cpp 64d707d 
>   sheets/part/dialogs/PageLayoutDialog.cpp e9165b9 
> 
> Diff: http://git.reviewboard.kde.org/r/108221/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130106/b80a6511/attachment.htm>


More information about the calligra-devel mailing list