Review Request: Add media support for epub3

Inge Wallin inge at lysator.liu.se
Sun Jan 6 03:20:00 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108201/#review24784
-----------------------------------------------------------

Ship it!


Looks good now.  Good work!


filters/words/epub/exportepub2.cpp
<http://git.reviewboard.kde.org/r/108201/#comment19046>

    Hmm, what does this do?  Isn't it a null declaration, i.e. does nothing?


- Inge Wallin


On Jan. 5, 2013, 2:38 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108201/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 2:38 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Add Media support for epub3. For this feature we need a new file .smil (SMIL ML) that contains the media refrence.
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/exporthtml.cpp 03aa7b5 
>   filters/words/epub/exportepub2.cpp 268455b 
>   filters/words/epub/OdtHtmlConverter.cpp d19ef54 
>   filters/words/epub/exportepub2.h 798f9c6 
>   filters/words/epub/OdtHtmlConverter.h 0245b9d 
> 
> Diff: http://git.reviewboard.kde.org/r/108201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130106/0ef74006/attachment.htm>


More information about the calligra-devel mailing list