Review Request: Fix wrong style applied when backspace

C. Boemann cbr at boemann.dk
Sat Jan 5 18:08:53 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108199/#review24768
-----------------------------------------------------------

Ship it!


Though I do not think this patch is enough long term - i see no problem with it for now

you can backport it too

- C. Boemann


On Jan. 5, 2013, 12:21 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108199/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2013, 12:21 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> When using backspace, we keep the char format of the deleted char. This should not apply when deleting across the newline boundary.
> 
> Ok to backport?
> 
> 
> This addresses bug 312584.
>     http://bugs.kde.org/show_bug.cgi?id=312584
> 
> 
> Diffs
> -----
> 
>   libs/kotext/commands/DeleteCommand.cpp 622062a 
> 
> Diff: http://git.reviewboard.kde.org/r/108199/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130105/5e9a1264/attachment.htm>


More information about the calligra-devel mailing list