Review Request: Fix applying style to a caret without a selection
C. Boemann
cbr at boemann.dk
Sat Jan 5 14:59:51 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108191/#review24745
-----------------------------------------------------------
Ship it!
yes it looks good - thank you
- C. Boemann
On Jan. 5, 2013, 7:35 a.m., Pierre Stirnweiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108191/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2013, 7:35 a.m.)
>
>
> Review request for Calligra and C. Boemann.
>
>
> Description
> -------
>
> When applying style to a caret without a selection, the previous character style properties, which are not set by the style being applied, were kept. We now reset the caret's format to the frame's text properties, apply the paragraph style's properties, and eventually the character style (if we set one).
>
> Ok to backport?
>
>
> Diffs
> -----
>
> libs/kotext/KoTextEditor_format.cpp 7bd345b
>
> Diff: http://git.reviewboard.kde.org/r/108191/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pierre Stirnweiss
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130105/8afe740b/attachment.htm>
More information about the calligra-devel
mailing list