Review Request: make parameters of KoTextEditor const refs if possible instead of passing by value

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108131/
-----------------------------------------------------------

Review request for Calligra, Pierre Stirnweiss and C. Boemann.


Description
-------

Looked all day at those lines, until I had the need to do something about it :)

Okay? 

For the visitor nethods I was not sure if the object to visit should be passed as ref or const ref, as the methods did not really say if they are supposed to be for read-only or modifying visits. So chose ref, to not restrict.


Diffs
-----

  libs/kotext/KoTextEditor.h e9e5234 
  libs/kotext/KoTextEditor.cpp 18a1972 
  libs/kotext/KoTextEditor_format.cpp 7bd345b 
  libs/kotext/KoTextEditor_p.h 823e888 
  libs/kotext/KoTextEditor_undo.cpp 73600d6 
  libs/kotext/changetracker/KoChangeTracker.h 65ed91f 
  libs/kotext/changetracker/KoChangeTracker.cpp dda52c7 
  libs/kotext/commands/DeleteCommand.cpp 622062a 

Diff: http://git.reviewboard.kde.org/r/108131/diff/


Testing
-------

"make test" results as before.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130103/a054e224/attachment.htm>