Impementation-dependent casts from uchar to char

Jaroslaw Staniek staniek at kde.org
Wed Jan 2 21:26:40 GMT 2013


Hello Marijn,
There are impementation-dependent casts from uchar to char:

filters/libmsooxml/MsooXmlImport.cpp: In member function
‘KTemporaryFile* MSOOXML::MsooXmlImport::tryDecryptFile(QString&)’:
filters/libmsooxml/MsooXmlImport.cpp:484:89: warning: narrowing
conversion of ‘254’ from ‘int’ to ‘const char’ inside { } is
ill-formed in C++11 [-Wnarrowing]

Since this is your code, could you point me what are these values?

            const char blockKeyData1[] = {0xfe, 0xa7, 0xd2, 0x76,
0x3b, 0x4b, 0x9e, 0x79};

Perhaps we can write them using signed char constansts, like QByteArray expects.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt Certified Specialist | http://qt-project.org
 http://www.linkedin.com/in/jstaniek



More information about the calligra-devel mailing list