Review Request: Have ok/cancel buttons consistently at the bottom in dialogs, not the right side

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108066/#review24381
-----------------------------------------------------------

Ship it!


OK for that, i.e. dropping Windows 3.11 UX. Additional checklist: let's use KDialogButtonBox in custom dialogs (if there are any, because KDialog uses it already). Reason: proper look & feel under GNOME.

- Jarosław Staniek


On Jan. 1, 2013, 5:02 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108066/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 5:02 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> A few dialogs in Sheets have the general buttons on the right side, not the bottom like these days almost all (KDE) dialogs have.
> 
> I would propose to have change those few dialogs to have the buttons at the bottom as well,
> even if the dialog then uses more space as needed in that compact form.
> 
> Attached patch fixes that for the CSV export dialog and the Conditional Styles dialog, as that is a simple one-line removal.
> 
> The other two places, Named Area dialog and Style Manager dialog, would need some more work, so I first wait for the okay before I post a patch for review here for those as well.
> 
> So okay to commit the attached patch and start work to change the two other dialogs as well?
> 
> Any other place known with buttons at the right side instead of the bottom (might be no KDialog-derived ones)?
> 
> 
> Diffs
> -----
> 
>   filters/sheets/csv/csvexportdialog.cpp d2fd2fc 
>   sheets/dialogs/ConditionalDialog.cpp f5b1e26 
> 
> Diff: http://git.reviewboard.kde.org/r/108066/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130101/915618f5/attachment.htm>