Review Request: Merge textshape-stylesWidget-PierreSt in master
C. Boemann
cbr at boemann.dk
Tue Jan 1 10:10:53 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108060/#review24358
-----------------------------------------------------------
Ship it!
Ship It!
- C. Boemann
On Jan. 1, 2013, 9:55 a.m., Pierre Stirnweiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108060/
> -----------------------------------------------------------
>
> (Updated Jan. 1, 2013, 9:55 a.m.)
>
>
> Review request for Calligra, Inge Wallin and C. Boemann.
>
>
> Description
> -------
>
> The branch has now functional StylesCombo with sorting of styles according to usage. The titles could use some artist/usability skills in order to stand out a bit more. However this is outside of my reach.
> There are some unused/commented out code that are foundations for later work i plan on doing.
>
>
> Diffs
> -----
>
> plugins/textshape/dialogs/AbstractStylesModel.h 6fddd0e
> plugins/textshape/dialogs/DockerStylesComboModel.h 933c83d
> plugins/textshape/dialogs/DockerStylesComboModel.cpp be83819
> plugins/textshape/dialogs/SimpleCharacterWidget.h 71fc022
> plugins/textshape/dialogs/SimpleCharacterWidget.cpp 744b8b9
> plugins/textshape/dialogs/SimpleParagraphWidget.h 6e0bed5
> plugins/textshape/dialogs/SimpleParagraphWidget.cpp 7337242
> plugins/textshape/dialogs/StylesCombo.h 4916ff1
> plugins/textshape/dialogs/StylesCombo.cpp 470903a
> plugins/textshape/dialogs/StylesDelegate.cpp 9ad9de5
> plugins/textshape/dialogs/StylesFilteredModelBase.h 4a81c0a
> plugins/textshape/dialogs/StylesFilteredModelBase.cpp f448a3c
> plugins/textshape/dialogs/StylesModel.h c904d39
> plugins/textshape/dialogs/StylesModel.cpp 5c42ff4
>
> Diff: http://git.reviewboard.kde.org/r/108060/diff/
>
>
> Testing
> -------
>
> Played around with the combo. Also fixed some issues spotted by Boemann earlier.
>
>
> Thanks,
>
> Pierre Stirnweiss
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130101/3af0f0f9/attachment.htm>
More information about the calligra-devel
mailing list