Review Request 109123: Set the freehand tool curve exactness default value to 1
Boudewijn Rempt
boud at valdyas.org
Thu Feb 28 18:21:34 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109123/#review28284
-----------------------------------------------------------
libs/basicflakes/tools/KoPencilTool.h
<http://git.reviewboard.kde.org/r/109123/#comment21127>
Yes, I am fine with this change -- though I wonder if it wouldn't be nicer to keep the actual variable private in the base class and create a protected getter/setter.
- Boudewijn Rempt
On Feb. 24, 2013, 7:45 a.m., Somsubhra Bairi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109123/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2013, 7:45 a.m.)
>
>
> Review request for Calligra and Boudewijn Rempt.
>
>
> Description
> -------
>
> Set the freehand tool curve exactness default value to 1
>
>
> This addresses bug 313593.
> http://bugs.kde.org/show_bug.cgi?id=313593
>
>
> Diffs
> -----
>
> krita/plugins/tools/defaulttools/kis_tool_pencil.cc aace615
> libs/basicflakes/tools/KoPencilTool.h 0d586c4
>
> Diff: http://git.reviewboard.kde.org/r/109123/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Somsubhra Bairi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130228/ea7c4f5f/attachment.htm>
More information about the calligra-devel
mailing list