Review Request 109163: Create SimpleSpellCheckWidget

C. Boemann cbr at boemann.dk
Wed Feb 27 08:36:24 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109163/#review28191
-----------------------------------------------------------


almost there


plugins/textshape/dialogs/SimpleSpellCheckingWidget.h
<http://git.reviewboard.kde.org/r/109163/#comment21070>

    I'm sorry, I meant ReviewTool



plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui
<http://git.reviewboard.kde.org/r/109163/#comment21069>

    You should have a QWidget named SpecialSpacer too.
    
    See the other Simple* widgets for example
    
    It should be just a plain QWidget at the bottom. The purpose I won't bother to explain, just take my word for it


- C. Boemann


On Feb. 27, 2013, 4:19 a.m., Luke De Mouy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109163/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2013, 4:19 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Created the SimpleSpellCheckWidget class and .ui file, has one KAction entitled tool_auto_spellcheck which is parented by the QToolButton ui->tool_auto_spellcheck
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/CMakeLists.txt 4cd1b91 
>   plugins/textshape/dialogs/SimpleSpellCheckingWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleSpellCheckingWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109163/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luke De Mouy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130227/a61cd087/attachment.htm>


More information about the calligra-devel mailing list