Review Request 109108: sync hardcoded mimetypes in Calligra Active code with those in calligraactive.desktop

Friedrich W. H. Kossebau kossebau at kde.org
Fri Feb 22 23:42:10 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109108/
-----------------------------------------------------------

Review request for Calligra and Shantanu Tushar.


Description
-------

Follow-up to http://git.reviewboard.kde.org/r/108996

Inside CalligraActive code the mimetypes are hardcoded a second time, in the overloads of CAAbstractDocumentHandler::supportedMimetypes().
This seems needed, because Calligra Active as a single app supports three kinds of documents, so first has to check by the mimetypes which of the three 
document kind handler has to be used.

Attached patch is a workaround for the principal problem, syncs the list of mimetypes in the handler with those in calligraactive.desktop .

See also email "Problems with Calligra Active and mimetypes" to mailinglist calligra-devel.

Okay to backport to 2.6?


Diffs
-----

  active/src/CAPresentationHandler.cpp 319c60f 
  active/src/CASpreadsheetHandler.cpp 62670e8 
  active/src/CATextDocumentHandler.cpp 5f4db02 

Diff: http://git.reviewboard.kde.org/r/109108/diff/


Testing
-------

Applied patch for package for Plasma Active, loads a lot more files now

(already merged into main repo, see https://build.pub.meego.com/package/files?package=calligra&project=Project%3AKDE%3ADevel )


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130222/4cb15cb0/attachment.htm>


More information about the calligra-devel mailing list