Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109082/
-----------------------------------------------------------

(Updated Feb. 22, 2013, 11:01 a.m.)


Review request for Calligra, C. Boemann, Yue Liu, and Thorsten Zachmann.


Changes
-------

Yue, adding you to have you please check if this patch will not break stuff for OS X packaging. Think it should not, but you are the expert :)


Description
-------

Splitting out the app-related files from the part/ directory makes the sources easier to grasp (should also help beginners with Calligra code). And it also results in having the complete sources for the product "Stage executable" and "Words executable" in a separate dir structure, so decision about building it or not is not some if-defed longer span in a CMakeLists.txt file (of part/), but instead can be done in simply-to-overlook lines in the dir level above, like
--- 8< ---
if (SHOULD_BUILD_WORDS_APP)
    add_subdirectory( app )
endif (SHOULD_BUILD_WORDS_APP)
--- 8< ---

In preparation for https://git.reviewboard.kde.org/r/109071/ which currently also includes this changes.

Possibly should be done for all programs which have such a part/ dir and still include the app-related files there. But for now only Sheets, Stage and Words are to be separated in two products each, the core/part (also used by CalligraActive) and the executable (not needed with CalligraActive).


Diffs
-----

  words/app/main.cpp PRE-CREATION 
  words/app/words.desktop PRE-CREATION 
  words/part/CMakeLists.txt 56b8c6f 
  words/part/Info.plist.template 97e1728 
  words/part/main.cpp 875eb5d 
  words/part/words.desktop 35bc4c3 
  stage/app/stage.desktop PRE-CREATION 
  stage/part/CMakeLists.txt de57a0f 
  stage/part/Info.plist.template 857a8d7 
  stage/part/main.cpp 5ef9509 
  stage/part/stage.desktop 447858f 
  words/CMakeLists.txt e6336a2 
  words/Messages.sh 3f2c3d2 
  words/app/CMakeLists.txt PRE-CREATION 
  words/app/Info.plist.template PRE-CREATION 
  stage/CMakeLists.txt 94dd31c 
  stage/app/CMakeLists.txt PRE-CREATION 
  stage/app/Info.plist.template PRE-CREATION 
  stage/app/main.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109082/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130222/e47c4b24/attachment.htm>