Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

[Friedrich W. H. Kossebau]

> On Feb. 21, 2013, 7:01 p.m., C. Boemann wrote:
> > perfectly fine with me, but two questions:
> > 
> > have you made sure it still works on mac, if not then we probably should ask yue
> > 
> > are there any changes needed for message extraction, and are we now talking different po packages?

Ah, good hint, Words just collects messages from part/, missed that, as Stage simply does a grep over everything and has the part ensure the catalog loading. The (only) Words plugin has its own Messages.sh... and is disabled anyway. So will update the patch with having Words main Messages.sh to also include the one string from app/. No need to have a separate catalog for that one string.

For Mac testing, no, cannot do that, so relying on yue (or boud soon?) to give that a look.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109082/#review27861
-----------------------------------------------------------


On Feb. 21, 2013, 5:24 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109082/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 5:24 p.m.)
> 
> 
> Review request for Calligra, C. Boemann and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> Splitting out the app-related files from the part/ directory makes the sources easier to grasp (should also help beginners with Calligra code). And it also results in having the complete sources for the product "Stage executable" and "Words executable" in a separate dir structure, so decision about building it or not is not some if-defed longer span in a CMakeLists.txt file (of part/), but instead can be done in simply-to-overlook lines in the dir level above, like
> --- 8< ---
> if (SHOULD_BUILD_WORDS_APP)
>     add_subdirectory( app )
> endif (SHOULD_BUILD_WORDS_APP)
> --- 8< ---
> 
> In preparation for https://git.reviewboard.kde.org/r/109071/ which currently also includes this changes.
> 
> Possibly should be done for all programs which have such a part/ dir and still include the app-related files there. But for now only Sheets, Stage and Words are to be separated in two products each, the core/part (also used by CalligraActive) and the executable (not needed with CalligraActive).
> 
> 
> Diffs
> -----
> 
>   stage/CMakeLists.txt 94dd31c 
>   stage/app/CMakeLists.txt PRE-CREATION 
>   stage/app/Info.plist.template PRE-CREATION 
>   stage/app/main.cpp PRE-CREATION 
>   stage/app/stage.desktop PRE-CREATION 
>   stage/part/CMakeLists.txt de57a0f 
>   stage/part/Info.plist.template 857a8d7 
>   stage/part/main.cpp 5ef9509 
>   stage/part/stage.desktop 447858f 
>   words/CMakeLists.txt e6336a2 
>   words/app/CMakeLists.txt PRE-CREATION 
>   words/app/Info.plist.template PRE-CREATION 
>   words/app/main.cpp PRE-CREATION 
>   words/app/words.desktop PRE-CREATION 
>   words/part/CMakeLists.txt 56b8c6f 
>   words/part/Info.plist.template 97e1728 
>   words/part/main.cpp 875eb5d 
>   words/part/words.desktop 35bc4c3 
> 
> Diff: http://git.reviewboard.kde.org/r/109082/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130221/35488f0f/attachment.htm>