Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

Boudewijn Rempt boud at valdyas.org
Thu Feb 21 18:09:54 GMT 2013 


> On Feb. 21, 2013, 8:08 a.m., Boudewijn Rempt wrote:
> > CMakeLists.txt, line 46
> > <http://git.reviewboard.kde.org/r/109071/diff/1/?file=114664#file114664line46>
> >
> >     Not only code: CREATIVEONY is used in many scripts for compiling Krita provided by 3rd parties, like David Revoy, it's in Portfiles for MacPorts, in emerge settings. I think we need a compatibility setting at least until 2.9
> 
> Friedrich W. H. Kossebau wrote:
>     Until 2.9 even? Surprised, but if you think so... Perhaps we could make the warning even bigger ;)

Yeah -- the thing is, we're talking about a pretty big outside-calligra dependency on CREATIVEONLY, which has been advertised quite widely for years now. I'm sure that we need at least two full releases before everyone has seen the deprecation message, and even then, for 2.9, we might need to make sure cmake quits with an error if CREATIVEONLY is present.


> On Feb. 21, 2013, 8:08 a.m., Boudewijn Rempt wrote:
> > CMakeLists.txt, line 99
> > <http://git.reviewboard.kde.org/r/109071/diff/1/?file=114664#file114664line99>
> >
> >     Okular is in Plasma Active, so I'd say, yes.
> 
> Friedrich W. H. Kossebau wrote:
>     I am unsure about the different purposes of OkularActive and CalligraActive (which is why I marked that as TODO). In the long run CalligraActive should be also an editor AFAIK, but currently more or less is also just a Viewer.
>     With the Stage part CalligraActive already offers display of ODP, and might be even the better app to do presentations I assume, due to native support. Thus enabling OkularActive for ODP by the Calligra ODP plugin would be unneeded duplication, or?

My argument was that if this is the build made for the Plasma Active platform, the okular plugin is useful, no matter whether Calligra Active is an editor or a viewer. It is kind of unneeded duplication, that is true. So maybe indeed skip it after all.


> On Feb. 21, 2013, 8:08 a.m., Boudewijn Rempt wrote:
> > filters/sheets/CMakeLists.txt, line 5
> > <http://git.reviewboard.kde.org/r/109071/diff/1/?file=114666#file114666line5>
> >
> >     Hm, this is tricky. These filters for more or less obsolete formats were disabled in TINY because there was no space on mobile devices for them, and very little need. Maybe we need something extra to prune the set of filters?
> >     
> >     Something like was done for the plugins?
> 
> Friedrich W. H. Kossebau wrote:
>     Possibly. Though tablets might not be that restrictive in resources like phones, so I would argue to go for everything that is possible.
>     Especially as packagers could still split filters into individual packages, so building everything does not mean to have everything in one single big installer (hopefully CalligraActive platforms/distris will be package-system-friendly).
>     
>     For other possible mobile device targets we might want to do it different, yes. I would still argue to wait for those use-cases and then adapt with the exact needs known. Indeed possibly could be done for plugins.
>     For CalligraActive the current patch should be fine.
>     
>     I am also hesitating because I hope that we will find a better way to define product sets, like in an external file. The current approach is not really scaling, also not easy to adapt for custom needs without hacking the CMakeLists.txt. So I only want to use the current approach where really needed, so when changing to something else less work needs to be done. :)

Okay, fine with me.


> On Feb. 21, 2013, 8:08 a.m., Boudewijn Rempt wrote:
> > plugins/CMakeLists.txt, line 53
> > <http://git.reviewboard.kde.org/r/109071/diff/1/?file=114669#file114669line53>
> >
> >     pictureshape is not relevant for Karbon either.
> 
> Friedrich W. H. Kossebau wrote:
>     Which plugin offers the insertion of image files in Karbon? Isn't it the pictureshape? And people want to insert pixel images in Karbon, at least I do :)

Aw, I was confusing it with the vectorshape, I guess.


> On Feb. 21, 2013, 8:08 a.m., Boudewijn Rempt wrote:
> > stage/app/CMakeLists.txt, line 1
> > <http://git.reviewboard.kde.org/r/109071/diff/1/?file=114672#file114672line1>
> >
> >     Wouldn't it be better to have the moving of stuff to app directories in a separate patch, or at least commit?
> 
> Friedrich W. H. Kossebau wrote:
>     Uploaded as separate patch https://git.reviewboard.kde.org/r/109082/

Cool.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109071/#review27811
-----------------------------------------------------------


On Feb. 21, 2013, 1:55 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109071/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 1:55 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> PRODUCTSET is a substitute for the old non-exclusive options CREATIVEONLY and TINY (which then are handled exclusively, eek), with migration support for CREATIVEONLY flag. Predefined hardcoded productsets are ACTIVE, CREATIVE, DESKTOP, and ALL (as fallback and default).
>     
> Patch also turns buildsystem to have a SHOULD_BUILD for each product (app/plugin), which then all get turned on centrally in groups depending on the productset, instead of everywhere having overlapping and hard to oversee if-else blocks deciding what gets build and what not.
> 
> Not the perfect final solution, but a first step into the right direction IMHO.
> 
> Known issues:
> * BUILD_AUTHOR is not yet set
> 
> Patch can be also tested as branch addProductSetBuildParameter-kossebau.
> 
> 
> Diffs
> -----
> 
>   words/part/CMakeLists.txt 56b8c6f 
>   words/part/Info.plist.template 97e1728 
>   words/part/main.cpp 875eb5d 
>   words/part/words.desktop 35bc4c3 
>   words/app/main.cpp PRE-CREATION 
>   words/app/words.desktop PRE-CREATION 
>   words/app/CMakeLists.txt PRE-CREATION 
>   words/app/Info.plist.template PRE-CREATION 
>   stage/part/Info.plist.template 857a8d7 
>   stage/part/main.cpp 5ef9509 
>   stage/part/stage.desktop 447858f 
>   tools/CMakeLists.txt eefe95b 
>   words/CMakeLists.txt e6336a2 
>   3rdparty/CMakeLists.txt a300bd2 
>   CMakeLists.txt d9945a1 
>   filters/CMakeLists.txt 5acecef 
>   filters/sheets/CMakeLists.txt 351a8e2 
>   filters/words/CMakeLists.txt 0c2107c 
>   libs/CMakeLists.txt 2036cf5 
>   plugins/CMakeLists.txt 0e87b1e 
>   sheets/CMakeLists.txt 9f96e41 
>   stage/CMakeLists.txt 94dd31c 
>   stage/app/CMakeLists.txt PRE-CREATION 
>   stage/app/Info.plist.template PRE-CREATION 
>   stage/app/main.cpp PRE-CREATION 
>   stage/app/stage.desktop PRE-CREATION 
>   stage/part/CMakeLists.txt de57a0f 
> 
> Diff: http://git.reviewboard.kde.org/r/109071/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130221/5d2ce5c6/attachment.htm>

More information about the calligra-devel mailing list