Review Request 109002: Turning stage into modebox

[C. Boemann]

> On Feb. 18, 2013, 5:47 p.m., Thorsten Zachmann wrote:
> > libs/kopageapp/tools/backgroundTool/CMakeLists.txt, lines 1-38
> > <http://git.reviewboard.kde.org/r/109002/diff/1/?file=114261#file114261line1>
> >
> >     These changes look suspisous. What is the reason for those?

because the tool is now defined in kopageapp lib prober, and this is just a plugin.

This way Stage is able to work on the tool


> On Feb. 18, 2013, 5:47 p.m., Thorsten Zachmann wrote:
> > libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h, line 30
> > <http://git.reviewboard.kde.org/r/109002/diff/1/?file=114262#file114262line30>
> >
> >     Why is this export needed?

Because stage needs to be able to work on the tool to add the layout widget


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109002/#review27643
-----------------------------------------------------------


On Feb. 18, 2013, 9:14 a.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109002/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 9:14 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Turns stage into modebox.
> Totaly remove the Stroke and Fill docker.
> Add the background fill widget, especialy needed in stage.
> 
> 
> Diffs
> -----
> 
>   flow/part/FlowView.cpp b30dbe9 
>   libs/kopageapp/CMakeLists.txt 35db53f 
>   libs/kopageapp/KoPAView.h 80b9f78 
>   libs/kopageapp/KoPAView.cpp 58b4940 
>   libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui 937e569 
>   libs/kopageapp/tools/backgroundTool/CMakeLists.txt 339c671 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h 45a240f 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 69f7649 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h cb75621 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp b803e79 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp c0c5afa 
>   libs/kopageapp/widgets/KoPABackgroundFillWidget.h PRE-CREATION 
>   libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp PRE-CREATION 
>   libs/widgets/KoFillConfigWidget.h 04b185a 
>   libs/widgets/KoFillConfigWidget.cpp d086eb7 
>   plugins/dockers/CMakeLists.txt dde9e22 
>   plugins/dockers/Plugin.cpp 9b6c442 
>   plugins/dockers/styledocker/StrokeFillWidget.h 212eaa0 
>   plugins/dockers/styledocker/StrokeFillWidget.cpp d67cabf 
>   plugins/dockers/styledocker/StyleButtonBox.h e2957fa 
>   plugins/dockers/styledocker/StyleButtonBox.cpp 291a5af 
>   plugins/dockers/styledocker/StyleDocker.h 13cf77f 
>   plugins/dockers/styledocker/StyleDocker.cpp ffec9c4 
>   plugins/dockers/styledocker/StyleDockerFactory.h acd91ac 
>   plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 
>   plugins/dockers/styledocker/StylePreview.h db33b3f 
>   plugins/dockers/styledocker/StylePreview.cpp 39f8b42 
>   plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 
>   stage/part/CMakeLists.txt de57a0f 
>   stage/part/KPrPageLayoutWidget.h PRE-CREATION 
>   stage/part/KPrPageLayoutWidget.cpp PRE-CREATION 
>   stage/part/KPrView.cpp 078b34b 
>   stage/part/dockers/KPrPageLayoutDocker.h ed7a547 
>   stage/part/dockers/KPrPageLayoutDocker.cpp e0e3113 
> 
> Diff: http://git.reviewboard.kde.org/r/109002/diff/
> 
> 
> Testing
> -------
> 
> I played around with the stage-designtool2-boemann branch.
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130219/6a66ac84/attachment.htm>