Review Request 108994: Normalize some SIGNAL and SLOT signatures

Inge Wallin inge at lysator.liu.se
Sun Feb 17 15:44:58 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108994/
-----------------------------------------------------------

Review request for Calligra and Shantanu Tushar.


Description
-------

I added a tool to normalize SIGNAL and SLOT signatures to tools/fixsrc.py. This patch is the result of the first run of this tool. I chose to start with Calligra Active because it had the shortest list of unnormalized connects. 

I can't see anything wrong with the output but I'm not comfortable with this concept yet to just commit it, hence this review request.


Diffs
-----

  active/src/CAPAView.cpp 1d6f9d4 
  active/src/CAPresentationHandler.cpp b0ff628 
  active/src/CASpreadsheetHandler.cpp ccbe9a5 
  active/src/CATextDocumentHandler.cpp 1b36c4d 
  active/src/MainWindow.cpp c77ea23 

Diff: http://git.reviewboard.kde.org/r/108994/diff/


Testing
-------


Thanks,

Inge Wallin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130217/4a7fb675/attachment.htm>


More information about the calligra-devel mailing list