Review Request 108979: Move KoShapeAnchor to flake

[C. Boemann]

> On Feb. 15, 2013, 6:56 p.m., Inge Wallin wrote:
> > libs/flake/KoShapeAnchor.cpp, line 361
> > <http://git.reviewboard.kde.org/r/108979/diff/1/?file=114122#file114122line361>
> >
> >     Hmm, shouldn't we try to use the same defaults?
> >

not so sure. I would prefer to have defaults specified somewhere though


> On Feb. 15, 2013, 6:56 p.m., Inge Wallin wrote:
> > libs/flake/KoShapeAnchor.h, lines 74-81
> > <http://git.reviewboard.kde.org/r/108979/diff/1/?file=114121#file114121line74>
> >
> >     These two methods probably need a deeper explanation. I don't understand them from the names only and the short explanation that's there.

trouble is I don't really know how to describe it as it's not really my code. The idea of being in a shape container is something form KWord days, but while revisiting it for Words it was investigated ad it surely is the best way to do it. No doubt here. it's just a bit of a gray area for me. And in any case it's difficult to describe it better in a Words neutral way


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108979/#review27529
-----------------------------------------------------------


On Feb. 15, 2013, 6:27 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108979/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 6:27 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This just moves the KoShapeAnchor class to flake
> 
> This is needed for, fixing pasting of shapes in the text tool, and for visualizing anchors
> 
> It doesn't really do anything new
> 
> Forgot to mention as it now is part of the shape it is no longer needed for words to keep track of it in KWFrame
> 
> 
> Diffs
> -----
> 
>   libs/flake/CMakeLists.txt 86a3456 
>   libs/flake/KoShape.h 77a630c 
>   libs/flake/KoShape.cpp a886277 
>   libs/flake/KoShapeAnchor.h PRE-CREATION 
>   libs/flake/KoShapeAnchor.cpp PRE-CREATION 
>   libs/flake/KoShape_p.h 7c769a8 
>   libs/kotext/CMakeLists.txt 2574b3d 
>   libs/kotext/KoShapeAnchor.h 436586e 
>   libs/kotext/KoShapeAnchor.cpp 3c64be2 
>   libs/kotext/opendocument/KoTextLoader.cpp 048d53a 
>   libs/kotext/opendocument/KoTextSharedLoadingData.h f7a6a7f 
>   libs/kotext/opendocument/KoTextSharedLoadingData.cpp a8b6d9c 
>   words/part/KWDocument.h 412284e 
>   words/part/KWDocument.cpp 563ac9f 
>   words/part/KWOdfSharedLoadingData.h 02a72de 
>   words/part/KWOdfSharedLoadingData.cpp a419647 
>   words/part/KWOdfWriter.cpp f4b5583 
>   words/part/KWRootAreaProvider.cpp 0c286f4 
>   words/part/KWView.cpp ccbf1e9 
>   words/part/commands/KWShapeCreateCommand.h 07a8921 
>   words/part/commands/KWShapeCreateCommand.cpp 4325f52 
>   words/part/dialogs/KWAnchoringProperties.cpp d936519 
>   words/part/frames/KWFrame.h 615654d 
>   words/part/frames/KWFrame.cpp c8677eb 
>   words/part/frames/KWFrameLayout.cpp 844359d 
> 
> Diff: http://git.reviewboard.kde.org/r/108979/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130215/1a7b8bd7/attachment.htm>