Review Request 108970: Fix options in the CSV Export dialog

Jarosław Staniek staniek at kde.org
Thu Feb 14 23:27:49 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108970/
-----------------------------------------------------------

Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, and Radosław Wicik.


Description
-------

Fix options in the CSV Export dialog

*Fix saving options for text quote and text encoding
*Fix function of "Default" button
*Pressing Cancel button should not save options

FIXED-IN:2.6.1


This addresses bug 314766.
    http://bugs.kde.org/show_bug.cgi?id=314766


Diffs
-----

  kexi/plugins/importexport/csv/kexicsvexportwizard.h 31b7dba163b3b9290144dfb8a4233e83683ddb18 
  kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 062ef0e5ecd706a35f62b6914d9123b60fde3e8a 
  kexi/plugins/importexport/csv/kexicsvwidgets.h 0e13e9f524463bfc8fce084df6a2653bc05a9b71 
  kexi/plugins/importexport/csv/kexicsvwidgets.cpp 230c5e62b990e266b965d954badb0be93caef849 
  kexi/widget/kexicharencodingcombobox.cpp ce6b97c608d7886a1833c8ccae4b9e35d54e12be 

Diff: http://git.reviewboard.kde.org/r/108970/diff/


Testing
-------

Executed exporter, clicked Default, tested Cancel and OK Buttons, save works


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130214/827dcbb8/attachment.htm>


More information about the calligra-devel mailing list