Review Request 108925: Fix Mobi and Epub filters problems

Inge Wallin inge at lysator.liu.se
Thu Feb 14 10:54:21 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108925/#review27435
-----------------------------------------------------------

Ship it!


Much better, ship it!

I still think that the fix for the crashes and the other fixes should be committed separately.

- Inge Wallin


On Feb. 13, 2013, 7:33 p.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108925/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 7:33 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I tested all documents that frinring sent to me, and found some problems in mobi (algorithm and in converting odf to mobi html) and in extracting
> images (external images) and in epub (bad handleing in tag bookmark).
> 
> Fixed all problems.
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/OdtHtmlConverter.cpp 373ef7e 
>   filters/words/epub/exportepub2.cpp 461cc9c 
>   filters/words/mobi/OdtMobiHtmlConverter.cpp de5ff3f 
>   filters/words/mobi/PalmDocCompression.cpp 1eff462 
>   filters/words/mobi/exportmobi.cpp fee2509 
> 
> Diff: http://git.reviewboard.kde.org/r/108925/diff/
> 
> 
> Testing
> -------
> 
> Tested with all documents that sent to me, all documents exported ok and without any problem.
> 
> 
> Thanks,
> 
> mojtaba shahi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130214/a444cd03/attachment.htm>


More information about the calligra-devel mailing list