Review Request 108937: Fix memory leak in KoShapeContainer

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108937/#review27432
-----------------------------------------------------------


In general it looks nice but for "other frames sets" you need to clean up too if the other frames are just copy frames. Like for instance the headers and footers

- C. Boemann


On Feb. 13, 2013, 6:15 a.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108937/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 6:15 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Fix memory leak in KoShapeContainer.
> 
> This fixes a big memoryleak resulting in quite a lot of shapes not getting deleted when the document is deleted.
> 
> This also fixes crashes on shutdown currently seen in cstester in quite some calligra words files.
> Problem for the crashes is that some shapes and QTextDocuments while others still trigger relayouting which uses the no longer deleted objects.
> 
> The patch fixes that by deleting the shapes and making sure there is no relayout when the stuff is deleted.
> 
> 
> Diffs
> -----
> 
>   krita/ui/flake/kis_shape_layer.cc 796b53c 
>   libs/flake/KoShapeContainer.cpp 93be3e1 
>   libs/kopageapp/KoPAPageBase.cpp 0b89a7b 
>   words/part/frames/KWFrame.cpp 552b04c 
>   words/part/frames/KWFrameSet.h 20b1bfc 
>   words/part/frames/KWFrameSet.cpp c002f4e 
>   words/part/frames/KWTextFrameSet.cpp f600a5b 
> 
> Diff: http://git.reviewboard.kde.org/r/108937/diff/
> 
> 
> Testing
> -------
> 
> Tested with cstester and the crashes seen before are gone.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130214/021b12eb/attachment.htm>