Review Request 108861: Improved Table handling for the HTML export filter

[Arjen Hiemstra]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108861/
-----------------------------------------------------------

(Updated Feb. 11, 2013, 1:27 p.m.)


Review request for Calligra.


Changes
-------

- Renamed cssStyleName to cssClassName because it is more accurate.
- Now filtering all illegal characters from the classname instead of just .
- Illegal characters get replaced with something that is not quickly used elsewhere.


Description
-------

This changes the HTML filter to more properly handle ODF tables. It now handles <table:table-header-rows> and <table:table-rows> elements, styling is applied properly and rowspan is supported.

Probably the biggest behavioural change is that style names are now filtered for illegal characters, currently specifically "." which was used in the table styles.


Diffs (updated)
-----

  filters/words/epub/OdtHtmlConverter.h dd753aa 
  filters/words/epub/OdtHtmlConverter.cpp 6564cd3 

Diff: http://git.reviewboard.kde.org/r/108861/diff/


Testing
-------

Exported both a simple table with no headers and a more complex table with headers. Both now look much more like what it looks like in Words.


Thanks,

Arjen Hiemstra

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130211/2abdf15b/attachment.htm>