Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

C. Boemann cbr at boemann.dk
Mon Feb 11 12:44:23 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108781/#review27195
-----------------------------------------------------------


Please follow the advice I give below, and then just continue with porting some of the other similar methods

sorry for being slow in getting back to you


libs/kotext/KoTextEditor_format.cpp
<http://git.reviewboard.kde.org/r/108781/#comment20470>

    ok this will have to go still
    
    the bug you reported will have to be fixed in mergeAutoStyle similar to how it's fixed in setStyle(KoCharacterStyle


- C. Boemann


On Feb. 5, 2013, 3:29 p.m., Sudhendu Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108781/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2013, 3:29 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Moving formatting from old framework to new framework. This patch only contains for bold. Once this is approved, same can be done for other formattings as well.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor_format.cpp 5a35fe8 
>   libs/kotext/KoTextEditor_undo.cpp 8dba444 
> 
> Diff: http://git.reviewboard.kde.org/r/108781/diff/
> 
> 
> Testing
> -------
> 
> Works well for me.
> 
> 
> Thanks,
> 
> Sudhendu Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130211/83f52b4b/attachment.htm>


More information about the calligra-devel mailing list