Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

[Sudhendu Kumar]

> On Feb. 4, 2013, 6:56 p.m., C. Boemann wrote:
> > libs/kotext/KoTextEditor_format.cpp, line 80
> > <http://git.reviewboard.kde.org/r/108781/diff/1/?file=112154#file112154line80>
> >
> >     this shouldn't be there

If I dont add this line, following use-case fails :-
User opens a blank document, clicks on Bold formatting, starts typing in bold format.
Observed scenario is that Bold button doesn't work.

Another way to put it can be that, bold formatting without making selection stops working.


> On Feb. 4, 2013, 6:56 p.m., C. Boemann wrote:
> > libs/kotext/KoTextEditor_format.cpp, line 85
> > <http://git.reviewboard.kde.org/r/108781/diff/1/?file=112154#file112154line85>
> >
> >     not sure but i think this needs to stay too.
> >     
> >     unless it's already done in mergeAutoStyle

Already there in mergeAutoStyle


> On Feb. 4, 2013, 6:56 p.m., C. Boemann wrote:
> > libs/kotext/KoTextEditor_format.cpp, line 84
> > <http://git.reviewboard.kde.org/r/108781/diff/1/?file=112154#file112154line84>
> >
> >     this line should be kept too. it's very important to "close" the editing (in terms of undo/redo)

Added in new patch


> On Feb. 4, 2013, 6:56 p.m., C. Boemann wrote:
> > libs/kotext/KoTextEditor_format.cpp, line 81
> > <http://git.reviewboard.kde.org/r/108781/diff/1/?file=112154#file112154line81>
> >
> >     this is not needed

Removed in new patch


- Sudhendu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108781/#review26639
-----------------------------------------------------------


On Feb. 4, 2013, 6:13 p.m., Sudhendu Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108781/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2013, 6:13 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Moving formatting from old framework to new framework. This patch only contains for bold. Once this is approved, same can be done for other formattings as well.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor_format.cpp 5a35fe8 
>   libs/kotext/KoTextEditor_undo.cpp 8dba444 
> 
> Diff: http://git.reviewboard.kde.org/r/108781/diff/
> 
> 
> Testing
> -------
> 
> Works well for me.
> 
> 
> Thanks,
> 
> Sudhendu Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130205/6355ffd8/attachment.htm>