Review Request 108096: Pimp KoReport section editor dialogs

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108096/#review26596
-----------------------------------------------------------


Good work, please look at the minor issues (I am sorry for changing my mind in two cases).


libs/koreport/wrtembed/detailgroupsectiondialog.ui
<http://git.reviewboard.kde.org/r/108096/#comment20199>

    Move the three checkboxes to left so they are aligned with Column/Sort rows - see http://wstaw.org/m/2013/02/03/plasma-desktopLK3862.png



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20206>

    Do not use separate label in this case, according to informal style guide, checkboxes with text property set are used when we're not aligning to other elements. Similar case like in "Enable the KDE wallet subsystem" in http://wstaw.org/m/2013/02/03/plasma-desktopcZ3862.png Then, do not append ":". 
    (I am sorry for changing my mind)
    



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20207>

    Do not use separate label in this case, see "Show report header" for more explanation. (I am sorry for changing my mind)



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20198>

    -> Page Header



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20200>

    -> Even pages:



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20205>

    -> Any pages:



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20201>

    -> Odd pages:



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20197>

    -> Page Footer



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20202>

    -> Even pages:



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20203>

    -> Any pages:



libs/koreport/wrtembed/sectioneditor.ui
<http://git.reviewboard.kde.org/r/108096/#comment20204>

    -> Odd pages:


- Jarosław Staniek


On Jan. 6, 2013, 1:24 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108096/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 1:24 a.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Reworked KoReport section editor dialogs, especially Ok/Cancel/Close dialog buttons. Oh, and now also these:
>     
> * base on KDialog
> * put labels in front of QCheckboxes
> * follow KDE UI guidelines for all text strings
> * disable buttons when no-ops
> * only offer columns for section grouping which are not used yet
> * do not leave an empty group on clicking Cancel during process of adding a new section group
> * skip empty field/key when offering fields for grouping
> * make API of ReportSectionDetail consistent (GroupSection where just Section was used)
> * removed any manually set spacings/margins, besides the 0 margins, looks less strange now
> 
> Better now? :)
> 
> And okay to backport to 2.6, without the string changes?
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/detailgroupsectiondialog.h df5504e 
>   libs/koreport/wrtembed/detailgroupsectiondialog.cpp ec0c84c 
>   libs/koreport/wrtembed/detailgroupsectiondialog.ui 32f4700 
>   libs/koreport/wrtembed/reportsectiondetail.h 3079d5a 
>   libs/koreport/wrtembed/reportsectiondetail.cpp 20b894e 
>   libs/koreport/wrtembed/reportsectiondetailgroup.h 94cebf4 
>   libs/koreport/wrtembed/sectioneditor.h 97a20c6 
>   libs/koreport/wrtembed/sectioneditor.cpp e7b9205 
>   libs/koreport/wrtembed/sectioneditor.ui ba9a337 
>   plan/libs/ui/reports/reportview.cpp dee77a6 
> 
> Diff: http://git.reviewboard.kde.org/r/108096/diff/
> 
> 
> Testing
> -------
> 
> Used in Kexi, works better as before.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130203/aa1c067d/attachment.htm>