Review Request 108725: Fix for unsetting the canvas, new approach

[C. Boemann]

> On Feb. 3, 2013, 10:20 a.m., C. Boemann wrote:
> > Okay, I've now tested in words, stage and sheets with all the combinations I can think which might have problems with this.
> > 
> > Not finding, and I like you solution as well, although the manual tweaks needed for modebox and krita are a little bit concerning, because when will it be needed the next time.
> > 
> > Can yuo elaborate a bit in the api dox please.
> > 
> > You can commit when you have done that, and you are also allowed to backport after a grace period of a few days
> > 
> >
> 
> Sven Langkamp wrote:
>     What do you want to add to the api dox?
>     
>     The changes in the applications are just unnecessary because of a non-standard way they use some things. For example the Modebox was setup after the canvas controller had already initialized the dockers, so it was buggy even before my change.

Okay, I just wanted something to say how the implementers should reimplement setcanvas() unsetCavas() still and that this is just for flake using it. And that its important to set it up before setting up the canvas controller, but if you don't do that then calling setObservedCanvas should be called manually.


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108725/#review26568
-----------------------------------------------------------


On Feb. 3, 2013, 4:35 a.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108725/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2013, 4:35 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The patch fixes the unset problem of request 108683. The previous patch had some side effect on Sheets. Now before unset it's check if the canvas of the KoCanvasObserve matches the one which is unset.
> 
> 
> This addresses bug 314029.
>     http://bugs.kde.org/show_bug.cgi?id=314029
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp 9bc51da 
>   libs/flake/KoCanvasControllerWidget.cpp a85337a 
>   libs/flake/KoCanvasObserverBase.h 927897c 
>   libs/flake/KoCanvasObserverBase.cpp 954fc2e 
>   libs/main/KoModeBox.cpp 1c81fa2 
>   sheets/part/View.cpp 3adb2f5 
>   words/part/KWGui.cpp 607db56 
> 
> Diff: http://git.reviewboard.kde.org/r/108725/diff/
> 
> 
> Testing
> -------
> 
> Fixes the bug in Krita. Didn't see side effects on other applications.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130203/09d710bf/attachment.htm>