Review Request 114467: Fix sheetssolver linking error on MSVC

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114467/#review46059
-----------------------------------------------------------



sheets/plugins/solver/CMakeLists.txt
<https://git.reviewboard.kde.org/r/114467/#comment32861>

    From http://www.cmake.org/cmake/help/git-master/command/target_link_libraries.html: Repeated calls for the same <target> append items in the order called.
    
    So in such cases, simper and slightly less error-prone approach is:
    
    target_link_libraries( sheetssolver
        ${GSL_LIBRARIES}
        calligrasheetscommon
    )
    if(WIN32)
        target_link_libraries( sheetssolver ${GSL_CBLAS_LIBRARIES} )
    endif(WIN32)
    


- Jarosław Staniek


On Dec. 22, 2013, 7:06 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114467/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2013, 7:06 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> gsl library references some symbols of gsl_cblas, so gsl_cblas library should be linked too.
> 
> 
> Diffs
> -----
> 
>   sheets/plugins/solver/CMakeLists.txt 83b097a 
> 
> Diff: https://git.reviewboard.kde.org/r/114467/diff/
> 
> 
> Testing
> -------
> 
> Builds using MSVC.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131222/55d17b7b/attachment.htm>