Review Request 114611: Workaround for duplicated include_directories

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114611/#review46049
-----------------------------------------------------------

Ship it!


Looks good.  I'm proxying boud here as a ship-it'er, but I agree that we should have this.

- Inge Wallin


On Dec. 22, 2013, 12:46 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114611/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2013, 12:46 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> CMake >= 2.8.8 does not remove duplicated entries from include_directories (I'm using 2.8.12.1), so we need a workaround until CMake fix it and even after they fix it until we support using those CMake versions.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4c37391 
>   krita/image/CMakeLists.txt f2fbcad 
> 
> Diff: https://git.reviewboard.kde.org/r/114611/diff/
> 
> 
> Testing
> -------
> 
> Applied the macro to a point where I was getting a too long command line and it fixed the problem.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131222/a066154d/attachment.htm>