Review Request 114457: Fix issuing rng2cpp on Windows.

Commit Hook null at kde.org
Sat Dec 21 22:01:25 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114457/#review46017
-----------------------------------------------------------


This review has been submitted with commit 911e112d45b8d3eb16758cbecdb8d528c532d4c3 by Andrius da Costa Ribas to branch calligra/2.8.

- Commit Hook


On Dec. 14, 2013, 5:28 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114457/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 5:28 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Last attempt to fix it won't work in a clean build, since find_program is issued before the actual executable is generated.
> According to http://www.cmake.org/Wiki/CMake_FAQ#How_do_I_generate_an_executable.2C_then_use_the_executable_to_generate_a_file.3F just passing the executable name to COMMAND would suffice (and works for me).
> I left the non-windows part untouched, as I can't test on linux.
> 
> 
> Diffs
> -----
> 
>   libs/odf/writeodf/CMakeLists.txt 9a99d48 
> 
> Diff: http://git.reviewboard.kde.org/r/114457/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131221/439ac7e0/attachment.htm>


More information about the calligra-devel mailing list