Review Request 114468: fix linking error on FillProcessingVisitorTest

[Boudewijn Rempt]

> On Dec. 17, 2013, 2:05 p.m., Dmitry Kazakov wrote:
> > Oh.. I guess it is better to just remove defaulttools linking in the test, because it is not needed anymore :) It was just a copy-paste error I guess.

Yes, I think so too. I don't actually build the tests on Windows myself, btw.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114468/#review45865
-----------------------------------------------------------


On Dec. 14, 2013, 9:19 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114468/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 9:19 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Since FillProcessingVisitorTest was moved (probably it was skipped before on Windows) I get a linker error because it tries to link to kritadefaulttools, which actually has the symbols exported but is set only as a plugin, meaning that no ".lib" is generated for the ".dll" file, which can't be linked directly.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/defaulttools/CMakeLists.txt 0aeb16a 
> 
> Diff: http://git.reviewboard.kde.org/r/114468/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131219/3004dfe6/attachment.htm>