Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114435/#review45653
-----------------------------------------------------------



karbon/ui/widgets/KarbonCanvas.cpp
<http://git.reviewboard.kde.org/r/114435/#comment32614>

    How about just removing the line instead of setting it to false.


- Thorsten Zachmann


On Dec. 13, 2013, 1:49 p.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114435/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 1:49 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The page rectangle and margins are strictly horizontal/vertical lines, so I don't think it makes sense to paint them anti-aliased. They look sharper when it's turned off. What do you think? (See before/after screenshot).
> 
> 
> Diffs
> -----
> 
>   karbon/ui/widgets/KarbonCanvas.cpp 4737040 
> 
> Diff: http://git.reviewboard.kde.org/r/114435/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before (with anti-aliasing)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/1e481a13-2d70-4242-bf7d-f10b7bce011a__before.png
> After (without anti-aliasing)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/c2057f12-6ee0-4239-8075-6536373a3f30__after.png
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131213/24955dfd/attachment.htm>