Review Request 114246: Move calligra version variables to cmake defines like in KDElibs

Commit Hook null at kde.org
Wed Dec 4 23:53:03 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114246/#review45153
-----------------------------------------------------------


This review has been submitted with commit 8b18b83a3f689c217ac1ec4b18698a5957ee6735 by Jaroslaw Staniek to branch master.

- Commit Hook


On Dec. 4, 2013, 11:29 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114246/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 11:29 p.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Move calligra version variables to cmake defines like in KDElibs
> 
> This exposes version info to CMake scripts.
> Extra: SOVERSION is automatically computed.
> 
> 
> Diffs
> -----
> 
>   libs/main/CMakeLists.txt c43696c 
>   CMakeLists.txt 6587ecc 
>   kexi/main/status/CMakeLists.txt de9b09a 
>   libs/main/calligraversion.h 4700d1a 
>   libs/main/calligraversion.h.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114246/diff/
> 
> 
> Testing
> -------
> 
> master configures, builds and installs, soversion is correct
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131204/5c9d23fd/attachment.htm>


More information about the calligra-devel mailing list