Review Request 114246: Move calligra version variables to cmake defines like in KDElibs

[Friedrich W. H. Kossebau]

> On Dec. 4, 2013, 11:17 p.m., Jarosław Staniek wrote:
> > CMakeLists.txt, line 44
> > <http://git.reviewboard.kde.org/r/114246/diff/1/?file=222037#file222037line44>
> >
> >     Yes, even patch releases can break BC: all calligra libs are currently private.
> >     
> >     Please note we use "<some_unique_integer_following_minor_version>.0.0".
> >     
> >     We would have "<some_unique_integer_following_minor_version>.<release>.0" but nothing more. Is that improvement for you?
> >     
> >     Reference: http://techbase.kde.org/index.php?title=Development/Tutorials/Creating_Libraries#Getting_the_version_numbers_right
> >

(While the libs are private we happily install headers for all of them. Ideally we just would not do that. But different problem, should not block this patch.)

Putting the <release> there would not help, as long as the ABI is broken and not backwards compatible (+ the problems with people downgrading the installed libs), no?
Am fine with this RR as is, really a different topic, just wanted to raise awareness, sorry for distracting too much perhaps.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114246/#review45150
-----------------------------------------------------------


On Dec. 4, 2013, 11:29 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114246/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 11:29 p.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Move calligra version variables to cmake defines like in KDElibs
> 
> This exposes version info to CMake scripts.
> Extra: SOVERSION is automatically computed.
> 
> 
> Diffs
> -----
> 
>   libs/main/CMakeLists.txt c43696c 
>   CMakeLists.txt 6587ecc 
>   kexi/main/status/CMakeLists.txt de9b09a 
>   libs/main/calligraversion.h 4700d1a 
>   libs/main/calligraversion.h.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114246/diff/
> 
> 
> Testing
> -------
> 
> master configures, builds and installs, soversion is correct
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131204/1ca737eb/attachment.htm>