Review Request 114246: Move calligra version variables to cmake defines like in KDElibs

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114246/#review45065
-----------------------------------------------------------

Ship it!



CMakeLists.txt
<http://git.reviewboard.kde.org/r/114246/#comment32231>

    While this is touched... anyone knows why the *.0.0 is not changed in bugfix releases?
    But then we do not yet care for ABI-stability in bugfix releases anyway, from what I have seen.
    
    Hopefully changes one day, and then we can also revisit this .0.0



libs/main/CMakeLists.txt
<http://git.reviewboard.kde.org/r/114246/#comment32229>

    Please rescue that lost whitespace :)



libs/main/calligraversion.h.cmake
<http://git.reviewboard.kde.org/r/114246/#comment32230>

    Ah, I was about to complain that this way doxygen will no longer be able to generate API dox for this methods, but seems it does for the kdelibs just fine, so nevermind :)



libs/main/calligraversion.h.cmake
<http://git.reviewboard.kde.org/r/114246/#comment32232>

    Oh, did not know about #cmakedefine, nice.
    Looked it up and then removed the previously written complain about "#ifdef CALLIGRA_ALPHA always yielding true!11!!" ;)
    


Looks good to me! At least /libs compiled also fine (did not test more) and the diff of original file and the one created by cmake also looked as expected.
I welcome this patch :)
++Automation

- Friedrich W. H. Kossebau


On Dec. 1, 2013, 10:35 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114246/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 10:35 p.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Move calligra version variables to cmake defines like in KDElibs
> 
> This exposes version info to CMake scripts.
> Extra: SOVERSION is automatically computed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6587ecc0eae0b59a5aa401c552b4a1ec6ecba62e 
>   kexi/main/status/CMakeLists.txt de9b09aeea0efba09003c4a0de78c7f2f2e95baa 
>   libs/main/CMakeLists.txt c43696c7b4c37ace2274cf327ef54fb235613095 
>   libs/main/calligraversion.h 4700d1a233b666c2200cf2df62e35c4b1787df31 
>   libs/main/calligraversion.h.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/114246/diff/
> 
> 
> Testing
> -------
> 
> master configures, builds and installs, soversion is correct
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131204/ed7e4aad/attachment.htm>