Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110821/#review44914
-----------------------------------------------------------


The code looks good. Only some minor points. If you run a cstester on it and it worked out ok I'm fine with committing this.


libs/flake/KoDocumentResourceManager.cpp
<http://git.reviewboard.kde.org/r/110821/#comment32098>

    The KoShapeController uses Q_DECLARE_METATYPE(KoShapeController *)
    which means that a cast to void on setting into a variant should not be needed. value<KoShapeController*> and setValue<ShapeController*> should work



libs/flake/KoToolProxy.cpp
<http://git.reviewboard.kde.org/r/110821/#comment32099>

    The indenetion is wrong here
    



libs/flake/KoToolProxy.cpp
<http://git.reviewboard.kde.org/r/110821/#comment32100>

    Is there any possibility that cmd is not there? From looking at the code I think that is not possible as it was created above and therefor the if/else can be removed and only keep the content between the if


- Thorsten Zachmann


On Nov. 19, 2013, 5:19 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110821/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 5:19 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Pasting of images of text and images was broken, because you could only paste text if the texttool was active, or you could only paste images if the default tool was active.
> 
> This patch changes it so that pasting of these things is now handled by toolproxy, so you are able to paste in all cases, unless the active tool consumes the data.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoDocumentResourceManager.h 27302a0 
>   libs/flake/KoDocumentResourceManager.cpp e42dc9d 
>   libs/flake/KoShapeAnchor.cpp 83087c3 
>   libs/flake/KoShapeController.cpp 817ba5e 
>   libs/flake/KoShapePaste.cpp 1457daf 
>   libs/flake/KoToolProxy.cpp 634a1ed 
>   libs/kotext/KoTextEditor.h 9fd3c05 
>   libs/kotext/KoTextEditor.cpp 40ac427 
>   libs/kotext/KoTextPaste.h 522ccce 
>   libs/kotext/KoTextPaste.cpp 2304d6a 
>   libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 044fd27 
>   libs/kotext/commands/TextPasteCommand.h 77d710a 
>   libs/kotext/commands/TextPasteCommand.cpp 34ea25c 
>   libs/kotext/opendocument/KoTextLoader.cpp 7831109 
>   libs/kotext/opendocument/KoTextSharedLoadingData.h 5ebb7a1 
>   libs/kotext/opendocument/KoTextSharedLoadingData.cpp d9a73e9 
>   libs/kotext/tests/TestKoTextEditor.h 60fe599 
>   libs/kotext/tests/TestKoTextEditor.cpp 75fa075 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp 68ba881 
>   plugins/textshape/TextShapeFactory.cpp d7e8fe8 
>   plugins/textshape/TextTool.cpp 96294a0 
>   words/part/KWView.cpp b299234 
> 
> Diff: http://git.reviewboard.kde.org/r/110821/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131201/fad070cf/attachment.htm>