Review Request 112405: Added three protected methods to KoCreatePathTool

Dmitry Kazakov dimula73 at gmail.com
Sat Aug 31 16:52:09 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112405/
-----------------------------------------------------------

(Updated Aug. 31, 2013, 3:52 p.m.)


Review request for Calligra.


Description
-------

This patch adds three protected methods for ending and canceling creation of the path in KoCreatePathTool. These protected methods are later used in the derived classes in Krita. This patch is necessary for fixing the path-finishing bugs in Krita.


This addresses bug https://bugs.kde.org/show_bug.cgi?id=322328.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=322328


Diffs
-----

  krita/plugins/tools/defaulttools/kis_tool_path.h 55e5c75 
  krita/plugins/tools/defaulttools/kis_tool_path.cc 709f14f 
  krita/plugins/tools/selectiontools/kis_tool_select_path.h 9214159 
  krita/plugins/tools/selectiontools/kis_tool_select_path.cc 7913a71 
  krita/ui/tool/kis_delegated_tool.h PRE-CREATION 
  krita/ui/tool/kis_tool.h e936d9d 
  libs/basicflakes/tools/KoCreatePathTool.h 101ad4e 
  libs/basicflakes/tools/KoCreatePathTool.cpp 8f0f547 
  libs/basicflakes/tools/KoCreatePathTool_p.h 51f4a8f 

Diff: http://git.reviewboard.kde.org/r/112405/diff/


Testing
-------

Tested in Krita


Thanks,

Dmitry Kazakov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130831/cb43d44a/attachment.htm>


More information about the calligra-devel mailing list