Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

[Thorsten Zachmann]

> On Aug. 21, 2013, 5:51 a.m., Thorsten Zachmann wrote:
> > libs/basicflakes/tools/KoCreatePathTool.cpp, line 415
> > <http://git.reviewboard.kde.org/r/111747/diff/3/?file=175416#file175416line415>
> >
> >     The activate is never called again. Is this correct?

Ok, after reading it is visible that this does not need to be unset as it sets a property of the widget. However that was not realy clear.


- Thorsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111747/#review38251
-----------------------------------------------------------


On July 30, 2013, 2:48 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111747/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 2:48 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> An earlier version of this patch has already been up for review before, but now is the time to ask for it to be merged
> 
> 
> Diffs
> -----
> 
>   flow/part/FlowView.cpp b30dbe9 
>   libs/basicflakes/tools/KoCreatePathTool.h 101ad4e 
>   libs/basicflakes/tools/KoCreatePathTool.cpp 8f0f547 
>   libs/basicflakes/tools/KoCreatePathTool_p.h 51f4a8f 
>   libs/flake/KoShape.h fd3349d 
>   libs/flake/KoShape.cpp 30774a8 
>   libs/flake/KoShape_p.h 27ff915 
>   libs/kopageapp/CMakeLists.txt 7cbf340 
>   libs/kopageapp/KoPAView.h 80b9f78 
>   libs/kopageapp/KoPAView.cpp bbb068a 
>   libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui 937e569 
>   libs/kopageapp/tools/backgroundTool/CMakeLists.txt 339c671 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h 45a240f 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 69f7649 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h cb75621 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp b803e79 
>   libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp 505c3da 
>   libs/kopageapp/widgets/KoPABackgroundFillWidget.h PRE-CREATION 
>   libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp PRE-CREATION 
>   libs/main/KoModeBox.cpp a653216 
>   libs/main/KoModeBoxDocker.cpp a6969fd 
>   libs/main/KoModeBoxDocker_p.h f480781 
>   libs/main/KoModeBox_p.h 2d54bf5 
>   libs/widgets/KoFillConfigWidget.h c2d8fca 
>   libs/widgets/KoFillConfigWidget.cpp 3948290 
>   libs/widgets/KoStrokeConfigWidget.h 8b37d48 
>   libs/widgets/KoStrokeConfigWidget.cpp 4f4ead8 
>   plugins/defaultTools/defaulttool/DefaultTool.cpp 0e77389 
>   plugins/dockers/CMakeLists.txt 16988b3 
>   plugins/dockers/Plugin.cpp 9b6c442 
>   plugins/dockers/styledocker/StrokeFillWidget.h 06082e4 
>   plugins/dockers/styledocker/StrokeFillWidget.cpp 1945a57 
>   plugins/dockers/styledocker/StyleButtonBox.h e2957fa 
>   plugins/dockers/styledocker/StyleButtonBox.cpp 291a5af 
>   plugins/dockers/styledocker/StyleDocker.h 6daa8f4 
>   plugins/dockers/styledocker/StyleDocker.cpp 9f86be9 
>   plugins/dockers/styledocker/StyleDockerFactory.h acd91ac 
>   plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 
>   plugins/dockers/styledocker/StylePreview.h da81351 
>   plugins/dockers/styledocker/StylePreview.cpp e196fe3 
>   plugins/textshape/TextShape.h 8190ab1 
>   plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 
>   stage/part/CMakeLists.txt 87df86c 
>   stage/part/KPrPageLayoutWidget.h PRE-CREATION 
>   stage/part/KPrPageLayoutWidget.cpp PRE-CREATION 
>   stage/part/KPrView.cpp fd6b762 
>   stage/part/dockers/KPrPageLayoutDocker.h ed7a547 
>   stage/part/dockers/KPrPageLayoutDocker.cpp 8348e2c 
>   words/part/frames/KWFrameLayout.cpp d778e1e 
> 
> Diff: http://git.reviewboard.kde.org/r/111747/diff/
> 
> 
> Testing
> -------
> 
> just working with it, and fixing the reviews from the earlier review
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130822/fc975102/attachment.htm>