Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author
C. Boemann
cbr at boemann.dk
Tue Aug 6 21:43:29 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111914/#review37234
-----------------------------------------------------------
general issues to look into:
- undo/redo of insertion and removal
- texttool to be adefault tool of anntationtextshape too
probably a lot more
libs/flake/KoAnnotationLayoutManager.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27536>
Somehow we need a more central place to define al these magic constants regarding geometry. This is just one place but there re many more places
libs/flake/KoShapeManager.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27537>
spelling in comment, but more importantly we need to find out if this is what we want
libs/kotext/KoTextEditor.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27538>
very important: need to look into the undo stack and be sure it works correctly
libs/kotext/opendocument/KoTextLoader.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27539>
This fixme seems obsolete
libs/textlayout/KoTextDocumentLayout.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27540>
This needs to be done right, and we need to handle the border with too
plugins/textshape/AnnotationTextShape.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27541>
check up with odf spec, and iteroperability
plugins/textshape/TextTool.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27542>
Hmm i guess, but let's think it over one more time
plugins/textshape/dialogs/SimpleAnnotationWidget.h
<http://git.reviewboard.kde.org/r/111914/#comment27543>
spaces
plugins/textshape/dialogs/SimpleAnnotationWidget.h
<http://git.reviewboard.kde.org/r/111914/#comment27544>
spaces
plugins/textshape/dialogs/SimpleAnnotationWidget.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27545>
it doesn't work but is set to enabled quickly by the reviewtool, because of a bug in Qt. Similar bu with all buttons in texttol
words/part/KWCanvas.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27546>
Again we need to have these geometric defines in one place, and i don't think the view is the right place
words/part/KWCanvasBase.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27547>
yes probably to the annotationlayoutmanager
words/part/KWDocument.cpp
<http://git.reviewboard.kde.org/r/111914/#comment27548>
again a constant
- C. Boemann
On Aug. 6, 2013, 4:59 p.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111914/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 4:59 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> This patch adds support for annotations to Words and Author.
>
> NOTE: We are aware that this patch is not yet ready for merge. The review request is as much for ourselves (ingwa, moji, boemann) as for others.
>
> The patch is large and rather complex so we use the review board to get an overview of the changes and to see early what we need to fix. There are still a number of bugs and not 100% of the features that we want to support are implemented.
>
> All of this said, annotations basically work now and you can check out the branch text-annotation if you want to test it. We would like to get some feedback already now so we can fix the issues early and provide a cleaner patch once we have finished the feature completely.
>
>
> Diffs
> -----
>
> ANNOTATIONS-ODF PRE-CREATION
> TODO-ANNOTATIONS PRE-CREATION
> libs/flake/CMakeLists.txt 7d03157
> libs/flake/KoAnnotationLayoutManager.h PRE-CREATION
> libs/flake/KoAnnotationLayoutManager.cpp PRE-CREATION
> libs/flake/KoShapeController.h 2ae03ca
> libs/flake/KoShapeController.cpp 817ba5e
> libs/flake/KoShapeManager.h 9df1671
> libs/flake/KoShapeManager.cpp 36666ce
> libs/kotext/KoAnnotation.h c4457fd
> libs/kotext/KoAnnotation.cpp e5a8a53
> libs/kotext/KoTextEditor.h 9fd3c05
> libs/kotext/KoTextEditor.cpp 40ac427
> libs/kotext/KoTextRangeManager.cpp fdde8ee
> libs/kotext/opendocument/KoTextLoader.cpp 7831109
> libs/textlayout/KoTextDocumentLayout.h a0fabcf
> libs/textlayout/KoTextDocumentLayout.cpp 1eec452
> plugins/textshape/AnnotationTextShape.h PRE-CREATION
> plugins/textshape/AnnotationTextShape.cpp PRE-CREATION
> plugins/textshape/AnnotationTextShapeFactory.h PRE-CREATION
> plugins/textshape/AnnotationTextShapeFactory.cpp PRE-CREATION
> plugins/textshape/CMakeLists.txt 2fec15f
> plugins/textshape/ReviewTool.h e2b8f95
> plugins/textshape/ReviewTool.cpp 53c87c7
> plugins/textshape/SimpleRootAreaProvider.cpp 30a74ab
> plugins/textshape/TextPlugin.cpp b99243f
> plugins/textshape/TextTool.cpp 37a376e
> plugins/textshape/dialogs/SimpleAnnotationWidget.h PRE-CREATION
> plugins/textshape/dialogs/SimpleAnnotationWidget.cpp PRE-CREATION
> plugins/textshape/dialogs/SimpleAnnotationWidget.ui PRE-CREATION
> words/part/KWCanvas.cpp f33d993
> words/part/KWCanvasBase.h 31111ce
> words/part/KWCanvasBase.cpp 22d1c5f
> words/part/KWDocument.h 7654aa3
> words/part/KWDocument.cpp 259fd4e
> words/part/KWOdfSharedLoadingData.cpp 450b580
> words/part/KWOdfWriter.cpp 1675bf1
> words/part/KWView.h 517cbc1
> words/part/KWView.cpp 48265fd
> words/part/KWViewModeNormal.cpp 88e67b2
> words/part/frames/KWTextFrameSet.cpp 1bb513c
> words/part/words.rc 31cabbd
>
> Diff: http://git.reviewboard.kde.org/r/111914/diff/
>
>
> Testing
> -------
>
> Created test files in LO with annotations and loaded them. Also created our own test files.
>
>
> Thanks,
>
> Inge Wallin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130806/4bebe897/attachment.htm>
More information about the calligra-devel
mailing list