Review Request 111787: Page Layout improvements for Words
Jérémy BOURDIOL
jerembo at wanadoo.fr
Fri Aug 2 22:24:43 BST 2013
> On Aug. 2, 2013, 8:37 p.m., Inge Wallin wrote:
> > Hi Jeremy! Very interesting patch.
> >
> > I wanted to go through this today but unfortunately my time ran out. I'm going to give it a test spin and review it during the weekend if nobody else does it before me.
Thanks your participation !
You will probably see some bugs if you make some strange movements. Report it, i will look at it after my holidays ;)
I forgot to say in the description that a large part of the code is from my friend Florian who started the feature.
After he left the branch a moment ago (he got lots of work), I made some adjustments and bug fixing.
- Jérémy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111787/#review37010
-----------------------------------------------------------
On July 29, 2013, 8:07 p.m., Jérémy BOURDIOL wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111787/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 8:07 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Huge feature on page layout started a moment ago.
>
> PageLayout improvement now allows users to :
> - resize margins directly with the mouse (still in debug)
> - resize page borders directly with the mouse (still in debug)
> - switch from portrait to landscape (and vise-versa) with one movement (vertical drag)
> - add and remove header/footer with a simple double-click in the corresponding half of the page
> - all changes could be see in the page layout dialog (in "page layout" section)
>
> The feature has still some problems (most of them graphical) in extrem uses, please checkout the branch and give your feelings.
>
>
> Diffs
> -----
>
> libs/widgets/KoPageLayoutDialog.h 7b0d029
> libs/widgets/KoPageLayoutWidget.cpp fd3667b
> words/part/CMakeLists.txt 4e2650c
> words/part/KWView.h 517cbc1
> words/part/KWView.cpp 48265fd
> words/part/author/CAuView.cpp 0c21610
> words/part/dialogs/KWPageSettingsDialog.h 30a25d3
> words/part/dialogs/KWPageSettingsDialog.cpp e046ac6
> words/part/pagetool/KWPageTool.h 45ad7d5
> words/part/pagetool/KWPageTool.cpp 7935390
> words/part/pagetool/SimpleHeaderFooterWidget.h 981d917
> words/part/pagetool/SimpleHeaderFooterWidget.cpp 75b4409
> words/part/pagetool/SimplePageStyleWidget.h PRE-CREATION
> words/part/pagetool/SimplePageStyleWidget.cpp PRE-CREATION
> words/part/pagetool/SimplePageStyleWidget.ui PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111787/diff/
>
>
> Testing
> -------
>
> A lot of manual tests.
>
> known bug :
> When resizing the page and the cursor is passing over the previous/next page a double textarea appears
>
>
> Thanks,
>
> Jérémy BOURDIOL
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130802/7f0ed752/attachment.htm>
More information about the calligra-devel
mailing list